CU-cn24gw CU-cn24dh Remove extension and higherkind annotations for Endo and Eval #316

danimontoya · 2021-01-26T12:17:26Z

Remove extension annotation for Endo
Remove extension and higherkind annotations for Eval
Deprecate extension for Endo
Deprecate extension EvalApplicative
Deprecate extension EvalApply
Deprecate extension EvalBimonad
Deprecate extension EvalComonad
Deprecate extension EvalFunctor
Deprecate extension EvalMonad

franciscodr · 2021-01-26T12:17:28Z

Task linked: CU-cn24dh Remove extension annotation Endo

franciscodr · 2021-01-26T12:17:28Z

Task linked: CU-cn24gw Remove extension annotation Eval

arrow-core/src/main/kotlin/arrow/core/extensions/endo/monoid/EndoMonoid.kt

nomisRev

Looks great! Only combine missing on Endo itself.

Deprecate extension methods for EvalApply.kt

arrow-core-data/src/main/kotlin/arrow/core/Endo.kt

…deprecated functions with *Kind

… time is increasing

# Conflicts: # arrow-core-data/src/main/kotlin/arrow/core/Eval.kt

Remove zip64 flag

nomisRev

A couple of incorrect deprecations, and nits.
Great work!! 👏 👏

arrow-core/src/main/kotlin/arrow/core/extensions/endo/monoid/EndoMonoid.kt

arrow-core-data/src/main/kotlin/arrow/core/Eval.kt

arrow-core/src/main/kotlin/arrow/core/extensions/eval/applicative/EvalApplicative.kt

arrow-core/src/main/kotlin/arrow/core/extensions/eval/apply/EvalApply.kt

arrow-core/src/main/kotlin/arrow/core/extensions/eval/comonad/EvalComonad.kt

arrow-core-data/src/main/kotlin/arrow/core/Eval.kt

nomisRev

Looks great @danimontoya! 👏 👏 👏 Thanks 🙏

danimontoya · 2021-02-02T11:21:10Z

@nomisRev thanks to you for all the reviews 🙌 😄

i-walker · 2021-02-03T08:58:52Z

arrow-core-data/src/main/kotlin/arrow/core/Eval.kt

+      c: Eval<C>,
+      map: (A, B, C) -> D
+    ): Eval<D> =
+      mapN(a, b, c, Unit, Unit, Unit, Unit, Unit, Unit, Unit) { aa, bb, cc, _, _, _, _, _, _, _ -> map(aa, bb, cc) }


nit:
with the kotlin naming conventions wouldn't we define Unit starting with a lowercase letter same there too

arrow-core/arrow-core-data/src/main/kotlin/arrow/core/Eval.kt

Lines 175 to 183 in 01781b8

val Unit: Eval<Unit> = Now(kotlin.Unit)

val True: Eval<Boolean> = Now(true)

val False: Eval<Boolean> = Now(false)

val Zero: Eval<Int> = Now(0)

val One: Eval<Int> = Now(1)

i-walker

Looks great @danimontoya 🙌
Just left a nit there, so those members are consistent across libraries in terms of naming conventions.

danimontoya added 2 commits January 26, 2021 13:04

Remove extension for EndoMonoid

4c0605a

Remove extension and higherkind for Eval

a6bc2c1

danimontoya requested review from raulraja, franciscodr, nomisRev and i-walker January 26, 2021 12:17

danimontoya marked this pull request as draft January 26, 2021 13:08

Deprecate @extension for Endo

a4df05d

nomisRev reviewed Jan 28, 2021

View reviewed changes

arrow-core/src/main/kotlin/arrow/core/extensions/endo/monoid/EndoMonoid.kt Outdated Show resolved Hide resolved

nomisRev suggested changes Jan 28, 2021

View reviewed changes

danimontoya added 10 commits January 28, 2021 17:45

Add combine for Endo and update ReplaceWith

4234bad

Add mapN for Eval

e2c54a9

Deprecate extension methods of EvalApplicative.kt

2550d47

Format and imports

dcbd5bf

Move mapN to companion object

42146c7

Deprecate extension methods for EvalApply.kt

Deprecate extension methods for EvalBimonad.kt

5e96e16

Deprecate extension methods for EvalComonad.kt

68e5714

Deprecate extension methods for EvalFunctor.kt

9cadbe8

Deprecate extension methods for EvalMonad.kt

cfb4630

Deprecate eval typeclasses interfaces

0fb0871

danimontoya marked this pull request as ready for review January 29, 2021 11:24

danimontoya requested a review from nomisRev January 29, 2021 11:30

nomisRev reviewed Jan 29, 2021

View reviewed changes

arrow-core-data/src/main/kotlin/arrow/core/Endo.kt Outdated Show resolved Hide resolved

danimontoya added 5 commits January 29, 2021 14:45

Refactor Endo.combine

a966d3c

Remove fix() from new added flatMap function and JvmName-rename some …

682001a

…deprecated functions with *Kind

Divide and win. Reducing number of flatmapping works.. although build…

e3882b7

… time is increasing

Increase Eval.mapN

0f6b764

Enable zip64

b431a41

danimontoya added 5 commits February 1, 2021 10:13

Add all mapN up until 10

b6f3bc5

Minor change

86f7e8f

Eval.mapN until 7 parameters works

282d270

Merge branch 'master' into dm-remove-extension-endo-eval

dae71b5

# Conflicts: # arrow-core-data/src/main/kotlin/arrow/core/Eval.kt

Remove inline-crossinline from mapN and flatMap functions

d42c57e

Remove zip64 flag

nomisRev reviewed Feb 2, 2021

View reviewed changes

Fix deprecation messages and imports from comments

7643c19

danimontoya requested a review from nomisRev February 2, 2021 11:09

nomisRev approved these changes Feb 2, 2021

View reviewed changes

Merge branch 'master' into dm-remove-extension-endo-eval

01781b8

i-walker reviewed Feb 3, 2021

View reviewed changes

i-walker approved these changes Feb 3, 2021

View reviewed changes

danimontoya added 2 commits February 3, 2021 10:29

Rename Unit -> unit so its not confused with kotlin.Unit

d949082

Merge branch 'master' into dm-remove-extension-endo-eval

01d57f1

danimontoya merged commit b50b2b8 into master Feb 3, 2021

danimontoya deleted the dm-remove-extension-endo-eval branch February 3, 2021 11:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CU-cn24gw CU-cn24dh Remove extension and higherkind annotations for Endo and Eval #316

CU-cn24gw CU-cn24dh Remove extension and higherkind annotations for Endo and Eval #316

danimontoya commented Jan 26, 2021 •

edited

franciscodr commented Jan 26, 2021

franciscodr commented Jan 26, 2021

nomisRev left a comment

nomisRev left a comment

nomisRev left a comment

danimontoya commented Feb 2, 2021

i-walker Feb 3, 2021

i-walker left a comment

	val Unit: Eval<Unit> = Now(kotlin.Unit)

	val True: Eval<Boolean> = Now(true)

	val False: Eval<Boolean> = Now(false)

	val Zero: Eval<Int> = Now(0)

	val One: Eval<Int> = Now(1)

CU-cn24gw CU-cn24dh Remove extension and higherkind annotations for Endo and Eval #316

CU-cn24gw CU-cn24dh Remove extension and higherkind annotations for Endo and Eval #316

Conversation

danimontoya commented Jan 26, 2021 • edited

franciscodr commented Jan 26, 2021

franciscodr commented Jan 26, 2021

nomisRev left a comment

Choose a reason for hiding this comment

nomisRev left a comment

Choose a reason for hiding this comment

nomisRev left a comment

Choose a reason for hiding this comment

danimontoya commented Feb 2, 2021

i-walker Feb 3, 2021

Choose a reason for hiding this comment

i-walker left a comment

Choose a reason for hiding this comment

danimontoya commented Jan 26, 2021 •

edited