This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscodr
reviewed
Feb 3, 2021
franciscodr
reviewed
Feb 3, 2021
franciscodr
reviewed
Feb 3, 2021
} | ||
|
||
override fun toString(): String = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering why we need the toString
method in the sealed class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's not needed if it's defined for all the cases.
Co-authored-by: Francisco Diaz <francisco.d@47deg.com>
franciscodr
approved these changes
Feb 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @nomisRev!
i-walker
approved these changes
Feb 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nomisRev Looks great
17 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
Show
since Kotlin, and Kotlin's Std doesn't takeShow
into account nor does Kotlin have the power to automatically derive or injectShow
anywhere. This makesShow
very cumbersome to work with, see Tuple10Show.kt.The use-cases of
Show
seemed very limited and niche to us, so we've decided to exclude it from Arrow in 1.0.0. The common technique for this is to usedata class
, which automatically implementstoString()
and correctly implementingtoString()
.