This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Deprecate @higherkind & @extension for Sequence/SequenceK #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
franciscodr
commented
Feb 5, 2021
franciscodr
commented
- Align
- Alternative
- Applicative
- Apply
- Crosswalk
- Eq (EqK)
- Foldable
- Functor
- FunctorFilter
- Monad
- MonadCombine
- MonadFilter
- MonadLogic
- MonadPlus
- Monoid (MonoidK)
- Monoidal
- Repeat
- Semialign
- Semigroup (SemigroupK)
- Semigroupal
- Traverse
- Unalign
- Unzip
- Zip
raulraja
reviewed
Feb 5, 2021
| @@ -148,8 +138,7 @@ fun <A> Sequence<A>.optional(): Sequence<Option<A>> = | |||
| @Deprecated( | |||
| "@extension kinded projected functions are deprecated", | |||
| ReplaceWith( | |||
| "guard(arg0)", | |||
| "arrow.core.extensions.sequence.alternative.Sequence.guard" | |||
| "if (arg0) sequenceOf(Unit) else emptySequence()" | |||
There was a problem hiding this comment.
should we be promoting in these replacements apis we are providing such as Sequence.unit otherwise we should question if Sequence.unit has value over sequenceOf(Unit)?
There was a problem hiding this comment.
We can't do Sequence.unit since we don't own Sequence, right?
I frequently use Either.unit() if I need to use Either in some kind of loop, and it's become a habit to use Either.unit() whenever I need Right(Unit). In general, however, I'd say that it's probably not very useful since it's a micro-optimization.
nomisRev
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Looks good to me. A couple of small things that need to be fixed added as suggestions.
Must've felt like a never-ending task 🙈 Thank you @franciscodr!
arrow-core/src/main/kotlin/arrow/core/extensions/sequence/eqK/SequenceKEqK.kt
Outdated
Show resolved
Hide resolved
arrow-core/src/main/kotlin/arrow/core/extensions/sequence/monoid/SequenceKMonoid.kt
Outdated
Show resolved
Hide resolved
arrow-core/src/main/kotlin/arrow/core/extensions/sequencek/eqK/SequenceKEqK.kt
Outdated
Show resolved
Hide resolved
arrow-core/src/main/kotlin/arrow/core/extensions/sequencek/monoid/SequenceKMonoid.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
nomisRev
approved these changes
Feb 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.