Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup publishing, dokka & knit #11

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented May 9, 2023

This PR cleans up the project a bit more, and sets up Dokka, Knit and configuration to publish to Sonatype/Maven Central 馃コ

It also moves the demo to documentation so it can be published on the Dokka website.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @nomisRev! 馃コ We'll need better examples and documentation but we're making great progress! When we finalize the 0.0.1 API, I'll try to spend some time adding KDoc + more/better examples.

@nomisRev nomisRev requested a review from franciscodr May 9, 2023 16:28
@nomisRev
Copy link
Member Author

nomisRev commented May 9, 2023

Perfect, I'll create the proposal PR for the refine DSL after this PR as we discussed in #8 馃憤 Then we'll be ready for an a first 0.0.1 release 馃コ

Whoever gives the second approval feel free to merge 鈽猴笍

Copy link
Collaborator

@ustitc ustitc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌

@ustitc
Copy link
Collaborator

ustitc commented May 9, 2023

@nomisRev btw, maybe it will be helpful, played a little bit with your proposal about refine DSL in krefty, definitely like it

https://github.com/ustits/krefty/blob/main/krefty-arrow/src/commonMain/kotlin/dev/ustits/krefty/arrow/Refinement.kt
https://github.com/ustits/krefty/blob/main/krefty-arrow/src/commonTest/kotlin/dev/ustits/krefty/arrow/RefinementTest.kt

@ILIYANGERMANOV ILIYANGERMANOV merged commit e036f41 into main May 9, 2023
4 checks passed
@nomisRev nomisRev deleted the publishing-dokka-knit branch May 9, 2023 18:06
@nomisRev
Copy link
Member Author

nomisRev commented May 9, 2023

@ustits nice 馃槏 If you're interested feel free to open a PR, then we can collaborate there as well. Otherwise I'll open one later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants