Ensure DSL for Exacts #13
Conversation
There was a problem hiding this comment.
This looks super awesome @ustits 🙌 Great work, I only have two small nits, so I am going to approve. We can update or change them later if we want to
Feel free to merge 🥳
PS: Not much to know about Knit, it seems you did great otherwise the build would've failed. It just makes sure that the code examples we write are valid. Then you run ./gradlew knit to update the tests or it fails on CI saying the knit is outdated.
| override fun from(value: A): Either<E, R> = either { construct(ExactScope(value, this)) } | ||
| } | ||
|
|
||
| public class ExactScope<A, E : Any>(public val raw: A, private val raise: Raise<E>) : Raise<E> by raise { |
There was a problem hiding this comment.
| public class ExactScope<A, E : Any>(public val raw: A, private val raise: Raise<E>) : Raise<E> by raise { | |
| public class ExactScope<A, E : Any>(public val raw: A, raise: Raise<E>) : Raise<E> by raise { |
Don't think this needs to be captured in case of delegation, right? 🤔
| object : Exact<A, R> { | ||
| override fun from(value: A): Either<ExactError, R> = either { construct(ExactScope(value, this)) } | ||
| } |
There was a problem hiding this comment.
Exact can be a fun interface that I look at it like this. It will be more performant, and look slightly better here.
| object : Exact<A, R> { | |
| override fun from(value: A): Either<ExactError, R> = either { construct(ExactScope(value, this)) } | |
| } | |
| Exact { value -> either { construct(ExactScope(value, this)) } } |
There was a problem hiding this comment.
You are right, also will change ExactEither
|
Thank you @ustits 🙌 |
ensuredsl forExactarrow.exactby my mistake)Decided to use
ensureinstead ofrefine, I think it will be better for users to have consistent naming throughout all Arrow modules.ensureaccepts otherExactso now it must be easier to combine them.The only problem is that I am not quite familiar with knit and probably have made something wrong, @nomisRev please fix me in that case 🙏
Feel free to change this PR!