This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Outstanding dequeues not completed on tryOffer1 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
commented
Aug 7, 2020
| @@ -79,15 +78,15 @@ internal interface Subscribe<A, Selector> { | |||
|
|
|||
| internal interface PubSub<I, O, Selector> : Publish<I>, Subscribe<O, Selector> { | |||
|
|
|||
| data class Publisher<A>(val token: Token, val i: A, val signal: Promise<Unit>) { | |||
| suspend fun complete(): Unit { | |||
| ForkConnected { signal.complete(Unit) } | |||
There was a problem hiding this comment.
It's not necessary to launch completion in a Fiber since the join operations already intercept before returning, meaning they always get properly re-scheduled before returning from join.
nomisRev
commented
Aug 7, 2020
| Pair(ps2, result) | ||
| } | ||
| val (ps2, action) = loop(ps1) { Unit } | ||
| Pair(ps2, { action.invoke(); result }) |
There was a problem hiding this comment.
This was the bug fix, in case an outstanding offer was found. Its completion needs to be invoked.
nomisRev
commented
Aug 7, 2020
| @@ -659,13 +658,13 @@ internal class DefaultPubSub<I, O, QS, S>(private val strategy: PubSub.Strategy< | |||
| */ | |||
| private tailrec fun loop( | |||
| ps: PubSub.PubSubState<I, O, QS, S>, | |||
| action: suspend () -> Unit | |||
| ): Pair<PubSub.PubSubState<I, O, QS, S>, (suspend () -> Unit)> { | |||
There was a problem hiding this comment.
The actions running in the loop no longer need to be suspending since we rely on UnsafePromise for signaling.
Instead the functionality of suspend is exposed through the modify operator.
danimontoya
approved these changes
Aug 7, 2020
JorgeCastilloPrz
approved these changes
Aug 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
updatefunction inPubSubwas not correctly invoking the completion for outstanding dequeues.To fix this I replaced the usages of
PromisetoUnsafePromiseso we can complete the promises in a non-suspending manner. This allows for bothmodifyandupdatewhich can modify the state withsuspend, andnon-suspendsupport.