Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Result doesn't need to be nullable #286

Merged
merged 3 commits into from Sep 29, 2020

Conversation

pablisco
Copy link
Contributor

@pablisco pablisco commented Sep 25, 2020

In the terminal operation firstOrError we return O?. However, there is possible way to return null as we throw an instance of NoSuchElementException.

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @pablisco!!

Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nomisRev
Copy link
Member

@pablisco I think it's best you pushed again to retrigger Actions with the changed workflow.

@pablisco pablisco merged commit 373525a into master Sep 29, 2020
@pablisco pablisco deleted the pablisco/firstOrError-not-nullable branch September 29, 2020 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants