Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Fix Schedule type in retry methods #297

Merged
merged 4 commits into from Nov 12, 2020
Merged

Fix Schedule type in retry methods #297

merged 4 commits into from Nov 12, 2020

Conversation

1Jajen1
Copy link
Member

@1Jajen1 1Jajen1 commented Oct 8, 2020

No description provided.

nomisRev
nomisRev approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're up for it, it'd be great to add some tests for retry.

@1Jajen1
Copy link
Member Author

1Jajen1 commented Oct 8, 2020

If you're up for it, it'd be great to add some tests for retry.

Yeah I'll do that. Should be pretty quick to add 👍

@nomisRev nomisRev requested a review from a team October 13, 2020 07:12
@nomisRev
Copy link
Member

Requested maintainers review for the second review 👍

aballano
aballano approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@aballano aballano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @1Jajen1!!

@1Jajen1 1Jajen1 merged commit 86bf8f3 into master Nov 12, 2020
@1Jajen1 1Jajen1 deleted the jo-fix-retry branch November 12, 2020 19:05
@1Jajen1
Copy link
Member Author

1Jajen1 commented Nov 12, 2020

Thanks @aballano 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aballano aballano aballano approved these changes

@nomisRev nomisRev nomisRev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@1Jajen1 @nomisRev @aballano