Add withConcurrentVar, modify and modify_ #298
Conversation
A few useful methods for manipulating ConcurrentVars safely using bracketCase
| ) | ||
|
|
||
| override suspend fun <B> modify(f: suspend (A) -> Tuple2<A, B>): B { | ||
| // ugly. Is there a better way? |
There was a problem hiding this comment.
This is the fastest and simplest implementation afaik. Just a tad ugly yes 😅
|
Well it is just composition so I don't think being very exhaustive in the tests is necessary, although 1-2 basic tests can't hurt to at least show that it works. I'll add something to docs, although this is best explained in the context of how to use |
|
Great tests and docs, thanks @1Jajen1! |
Also fail faster by not waiting for unfulfilled promises
| when (exit) { | ||
| is ExitCase.Failure -> put(a) | ||
| is ExitCase.Cancelled -> put(a) | ||
| is ExitCase.Completed -> put(res!!) |
There was a problem hiding this comment.
Should put(res!!) ever fail for some reason I'd rather have it crash than not put back the value because that could lead to a very confusing deadlock.
A few useful methods for manipulating ConcurrentVars safely using bracketCase.