Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Reduce iterations property tests and stack safety iterations #336

Merged
merged 6 commits into from Dec 16, 2020

Conversation

nomisRev
Copy link
Member

Status

READY

Description

Since arrow-fx (IO and effect typeclasses) are getting deprecated this version, and development has halted since last version we can safely reduce the iterations of the property based tests. This will reduce stress on CI, and time it takes to finish the CI actions. This also reduces the stress of Arrow Mtl which also runs effect typeclass tests.

Stack safety can be safely test with 5k iterations as well.

Todos

  • Tests
    - [ ] Documentation

Related PRs

  • None

@i-walker i-walker self-requested a review December 16, 2020 12:02
Copy link
Member

@i-walker i-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 That makes sense !

Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@1Jajen1 1Jajen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if 5k is enough to find stackoverflows in some weirder scenarios, but tbh I would also be fine with just not running tests for arrow-fx at all once its fully deprecated and unlikely to be changed anymore.

Copy link
Member

@rachelcarmena rachelcarmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!!! 🙌

@nomisRev nomisRev merged commit da751ce into master Dec 16, 2020
@nomisRev nomisRev deleted the sv-reduce-stress-tests-arrow-fx branch December 16, 2020 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants