Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

inline sleep and timeOutOrNull #358

Merged
merged 6 commits into from Dec 28, 2020
Merged

inline sleep and timeOutOrNull #358

merged 6 commits into from Dec 28, 2020

Conversation

i-walker
Copy link
Member

@i-walker i-walker commented Dec 23, 2020

  • allow experimental time Api in build settings
  • Inline sleep/ timeOutOrNull
  • Replace library usage of arrow.fx.coroutines.Duration to kotlin.time.Duration, besides in API Types, such as CircuitBreak or Schedule

Status

Ready

Description

In order to break the changes introduced in #338 into multiple PR's
Api's that still use arrow's Duration

This PR does not change usages in arrow.fx, because it will be removed #357

Related PRs

@i-walker i-walker marked this pull request as ready for review December 23, 2020 13:06
@i-walker i-walker requested a review from a team December 23, 2020 13:07
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @i-walker!

@i-walker i-walker requested a review from a team December 28, 2020 10:37
# Conflicts:
#	arrow-fx-coroutines-stream/src/main/kotlin/arrow/fx/coroutines/stream/Stream.kt
#	arrow-fx-coroutines/src/test/kotlin/arrow/fx/coroutines/CircuitBreakerTest.kt
#	arrow-fx-coroutines/src/test/kotlin/arrow/fx/coroutines/SemaphoreTest.kt
@i-walker i-walker merged commit c4de979 into master Dec 28, 2020
@i-walker i-walker deleted the is-inline branch December 28, 2020 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants