Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Deprecate arrow.fx.coroutines.Duration #366

Merged
merged 2 commits into from Jan 4, 2021
Merged

Conversation

i-walker
Copy link
Member

Issue

Initial deprecation cycle in favor of kotlin.time.Duration

links to:
#18

Status

READY

Description

This PR goes along with the changes introduced in #360 , #359

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only the ReplaceWith on Duration is broken atm, added fixed suggestion.

…on.kt

Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
@i-walker i-walker requested a review from a team December 30, 2020 12:12
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks @i-walker

@nomisRev nomisRev requested a review from a team January 4, 2021 09:10
Copy link
Contributor

@danimontoya danimontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@nomisRev nomisRev merged commit 3ca8e1f into master Jan 4, 2021
@nomisRev nomisRev deleted the deprecate-duration branch January 4, 2021 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants