Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

fix Circuit#protect #369

Merged
merged 18 commits into from Jan 8, 2021
Merged

fix Circuit#protect #369

merged 18 commits into from Jan 8, 2021

Conversation

i-walker
Copy link
Member

@i-walker i-walker commented Jan 6, 2021

  • removes protectOrNull
  • protectEither returns Either<ExecutionRejected, A>

Status

READY

Todos

  • Tests

Related PRs

  • None

i-walker and others added 18 commits December 23, 2020 22:16
# Conflicts:
#	arrow-fx-coroutines/src/test/kotlin/arrow/fx/coroutines/CircuitBreakerTest.kt
# Conflicts:
#	arrow-fx-coroutines/src/test/kotlin/arrow/fx/coroutines/CircuitBreakerTest.kt
# Conflicts:
#	arrow-fx-coroutines/src/test/kotlin/arrow/fx/coroutines/CircuitBreakerTest.kt
# Conflicts:
#	arrow-fx-coroutines/src/test/kotlin/arrow/fx/coroutines/CircuitBreakerTest.kt
…tBreaker.kt

Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
# Conflicts:
#	arrow-fx-coroutines/src/main/kotlin/arrow/fx/coroutines/Duration.kt
…tBreaker.kt

Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
# Conflicts:
#	arrow-fx-coroutines/src/main/kotlin/arrow/fx/coroutines/CircuitBreaker.kt
@i-walker i-walker requested a review from a team January 7, 2021 12:31
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks for the follow up PR @i-walker ! 👏 👏 👏

@i-walker i-walker merged commit 239932d into master Jan 8, 2021
@i-walker i-walker deleted the is-circuit branch January 8, 2021 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants