Add implementation for Can #109
Conversation
pablisco
changed the title
| SGR: Semigroup<R>, | ||
| b: Can<L, R> | ||
| ): Can<L, R> = when (val a = this) { | ||
| is Neither -> when (b) { |
…e being able to call it
|
Are we good with this? @aballano :) |
There was a problem hiding this comment.
Thanks @pablisco; @1Jajen1 may be interested in reviewing as @nomisRev pointed out since he is our most active MTL contributor. Also this needs docs for the site and docs. As we approach v1 we can just drop undocumented stuff in the public API since its a maintenance burden to explain individually what this does.
|
I'll look at this later today :) Did a quick skim right now and this seems really well done 👍 However I do have one question:This is not a transformer, why would we put this into mtl? I can understand keeping arrow-core slim, but mtl does not seem like the right place for this. I don't have a much better idea where to put it though, so it might be fine for now. |
There was a problem hiding this comment.
All in all this is really well done, i have just a few suggestions on the docs part (take or leave, it's mostly subjective anyway) and some other nits. I also think the monoid instance is broken atm and the property test generator could be improved.
As Raul said this needs an entry in the docs. You should be able to link the apidocs in the sidebar menu and that should be sufficient.
And lastly: This should not be in mtl. This is not a transformer, nor has it any dependency on any incubator code (or mtl specific code). If we don't want this in core we should at least discuss how to handle these datatypes and typeclasses. (In general there are some useful types and classes that don't really belong in core, but could be useful to offer in other libs.
Going forward with this: How should we continue here? @pakoito @raulraja @aballano
- Keep it around mtl for now and organize later?
- Merge it into core and split core later?
- Create something new now? (I'd hate to do this to this pr as it is close to complete, so one of the above is probably better)
arrow-mtl-data/src/test/kotlin/arrow/mtl/test/generators/Generators.kt
Outdated
Show resolved
Hide resolved
arrow-mtl-data/src/test/kotlin/arrow/mtl/test/generators/Generators.kt
Outdated
Show resolved
Hide resolved
|
IMO A new module called experimental can be added to the incubator with sub modules if needed to group topics. MTL is still in incubator because we are close to find a encoding that does not require Kinds for polymorphism and can interleave effects in suspension. I believe all these transformers could be rewritten that way and the types would be much easier without kinds. |
That does make sense to me as well. We could also add something like arrow-extras as a repo and get individual modules there for the more obscure and rare use types and typeclasses.
I'd love to drop mtl as soon as we have an actual effect system, do you have some links for this? I'd love to read up on it's attempted in arrow. |
Co-authored-by: Jannis <overesch.jannis@gmail.com>
Co-authored-by: Jannis <overesch.jannis@gmail.com>
Co-authored-by: Jannis <overesch.jannis@gmail.com>
Co-authored-by: Jannis <overesch.jannis@gmail.com>
Co-authored-by: Jannis <overesch.jannis@gmail.com>
Co-authored-by: Jannis <overesch.jannis@gmail.com>
Co-authored-by: Jannis <overesch.jannis@gmail.com>
Co-authored-by: Jannis <overesch.jannis@gmail.com>
Co-authored-by: Jannis <overesch.jannis@gmail.com>
|
Thank you @1Jajen1 for all the comments 🙇 I'll try to get through them over the weekend :) Btw, I'm happy to move Can somewhere more pertinent :) |
| Can.fromOptions(it.first, it.second) | ||
| } | ||
| } | ||
| private fun <A, B, R> Gen<A>.alignWith(genB: Gen<B>, transform: (Ior<A, B>) -> R): Gen<R> = |
There was a problem hiding this comment.
This is actually quite nice 👍 Might be possible to even define an instance for semialign on generators! (takes notes for arrow-check... 😅)
With kotest those will likely stay unlawful so this is perfectly fine!
There was a problem hiding this comment.
I can see GenK brewing here 😄
Transferred from arrow-kt/arrow-core#103
Implementation of
Canfrom the Haskell Smash package: https://hackage.haskell.org/package/smash-0.1.1.0/docs/Data-Can.htmlRelated to #108