AutoModule integration #122
Conversation
| include 'arrow-fx-mtl' | ||
| include 'arrow-incubator-test' | ||
| autoModule { | ||
| ignore(":arrow-docs") |
There was a problem hiding this comment.
I added this because on the previous setup there was no include for arrow-docs and I wasn't sure if that was in purpose.
There was a problem hiding this comment.
Yes, it's intentional. arrow-docs modules have a huge amount of dependencies so they are just included when generating API docs.
There was a problem hiding this comment.
Thank you so much @pablisco , super useful in order not to miss new modules 👏
| include 'arrow-fx-mtl' | ||
| include 'arrow-incubator-test' | ||
| autoModule { | ||
| ignore(":arrow-docs") |
There was a problem hiding this comment.
Yes, it's intentional. arrow-docs modules have a huge amount of dependencies so they are just included when generating API docs.
settings.gradle
Outdated
| plugins { | ||
| id "com.pablisco.gradle.automodule" version "0.12" | ||
| } | ||
|
|
There was a problem hiding this comment.
Please, create a branch with the same name in arrow repository and locate that version in gradle.properties (checks will take into account all the open pull requests with the same branch name).
There was a problem hiding this comment.
So sorry Pablisco, it's not working because properties are included via COMMON_SETUP in build.gradle. However, it's not possible to do the same for settings.gradle because of project consideration:
Could not get unknown property 'project' for settings 'arrow-incubator' of type org.gradle.initialization.DefaultSettings ('arrow/setup.gradle' line: 43')
So it should be changed. Please, create an issue to be able to have this version in arrow repository and it will be reviewed asap. Meanwhile, please, locate the version in settings.gradle as before. Sorry!
I'm testing to see if we can use autoModule with arrow projects.
Should, hopefully, make module management easier.