Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle-plugin: changes after checking the publication #69

Merged
merged 10 commits into from
Nov 5, 2019

Conversation

rachelcarmena
Copy link
Member

Goal

Solve the problems that have been found when publishing the plugin into Gradle repository:

  • Redefined the plugin twice with ArrowKotlinGradleSubplugin.kt.
  • Remove the artifact of compiler-plugin from the artifact of gradle-plugin. It couldn't be used in that way.
  • Remove the use of the path ${project.rootDir}/modules/meta/arrow-meta-prototype/compiler-plugin/build/libs/compiler-plugin.jar
  • Remove hardcoded versions to facilitate the release processes.

How to test it

When merging this pull request, the plugin will be published automatically with the version 0.10.3-rc-2 (the current published version is 0.10.3-rc-1).

Note

Gradle Plugin offers 2 options:

  • Use the plugins DSL
plugins {
    id "io.arrow-kt.arrow" version "0.10.3-rc-2"
}
  • Using the legacy plugin application:
buildscript {
    repositories {
        maven { url "https://plugins.gradle.org/m2/" }
    }
    dependencies {
        classpath "io.arrow-kt:gradle-plugin:0.10.3-rc-2"
    }
}

apply plugin: "io.arrow-kt.arrow"

However, in our case, we must document that it's only possible to use the second one, because it's necessary to include the repository to find compiler-plugin dependency which is in oss.jfrog.org right now:

buildscript {
    repositories {
        maven { url "https://plugins.gradle.org/m2/" }
        maven { url 'https://oss.jfrog.org/artifactory/oss-snapshot-local/' }
    }
    dependencies {
        classpath "io.arrow-kt:gradle-plugin:0.10.3-rc-2"
    }
}

apply plugin: "io.arrow-kt.arrow"

Otherwise, compiler-plugin will be searched in Gradle Plugins repository.

@raulraja
Copy link
Member

raulraja commented Nov 5, 2019

Thanks @rachelcarmena !

@rachelcarmena rachelcarmena merged commit 78b396a into release/gradle-plugin Nov 5, 2019
@rachelcarmena rachelcarmena deleted the fix/gradle-plugin branch November 5, 2019 19:22
@rachelcarmena rachelcarmena restored the fix/gradle-plugin branch November 6, 2019 06:37
@rachelcarmena rachelcarmena mentioned this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants