Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Deprecate Each typeclass #81

Merged
merged 5 commits into from Jan 12, 2021
Merged

Deprecate Each typeclass #81

merged 5 commits into from Jan 12, 2021

Conversation

franciscodr
Copy link
Contributor

As discussed in this PR, we're deprecating Each typeclass in favor of Traversal since Each simply summons a Traversal without any other benefit.

@franciscodr franciscodr requested a review from a team January 8, 2021 11:08
@franciscodr franciscodr changed the title Paco deprecate each typeclass Deprecate Each typeclass Jan 8, 2021
nomisRev
nomisRev approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!! Thanks @franciscodr!

@nomisRev nomisRev requested a review from a team January 11, 2021 13:04
raulraja
raulraja approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @franciscodr !

@franciscodr franciscodr merged commit e4c6acc into master Jan 12, 2021
@franciscodr franciscodr deleted the paco-deprecate-each-typeclass branch January 12, 2021 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@raulraja raulraja raulraja approved these changes

@nomisRev nomisRev nomisRev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@franciscodr @raulraja @nomisRev