This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Deprecate extensions methods for Set and SetK #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tylos
changed the title
Tylos
force-pushed
the
ty-deprecate-extensions-setk
branch
from
840247a
to
4b1904a
Compare
Tylos
commented
Jan 13, 2021
| ReplaceWith( | ||
| "At<SetK<A>, A, Boolean>", | ||
| "arrow.optics.typeclasses.At", "arrow.core.SetK"), | ||
| DeprecationLevel.WARNING) | ||
| interface SetKAt<A> : At<SetK<A>, A, Boolean> { |
There was a problem hiding this comment.
☝️
Wondering the reason we can get rid of these interfaces now. Is it because we do not need @extension any longer?
There was a problem hiding this comment.
They're public so users might be using them directly.
Tylos
force-pushed
the
ty-deprecate-extensions-setk
branch
from
4b1904a
to
20a975f
Compare
Align with team decision to move all instances creation to the typeclass companion object. Deprecate top level method used to obtain the instances before. Replace usages in optics module.
Tylos
force-pushed
the
ty-deprecate-extensions-setk
branch
from
20a975f
to
b60c64d
Compare
Tylos
commented
Jan 14, 2021
Tylos
commented
Jan 14, 2021
Tylos
commented
Jan 14, 2021
Tylos
commented
Jan 14, 2021
Tylos
force-pushed
the
ty-deprecate-extensions-setk
branch
from
b60c64d
to
558d058
Compare
franciscodr
reviewed
Jan 15, 2021
franciscodr
reviewed
Jan 15, 2021
franciscodr
reviewed
Jan 15, 2021
arrow-optics/src/main/kotlin/arrow/optics/extensions/setk/at/SetKAt.kt
Outdated
Show resolved
Hide resolved
|
@franciscodr thanks for the suggestions, all changes have been applied 🥳 |
franciscodr
approved these changes
Jan 15, 2021
|
Thanks @Tylos! |
nomisRev
approved these changes
Jan 15, 2021
|
Thanks @Tylos! |
Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
|
@nomisRev you are right, pasted twice than I copied 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.