Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

CU-9rrjbq Menu changes preparing for content specific to 1.0 #74

Merged
merged 11 commits into from Feb 9, 2021

Conversation

raulraja
Copy link
Member

@raulraja raulraja commented Feb 6, 2021

  • Removes references to incubator
  • Removes links to articles that where mostly encoded in terms of Kinds (to be reviewed in content PRs if content remains relevant)
  • Introduces Training && Support links currently pointing exclusively to 47 Degrees until other companies also want to announce themselves there. /cc @garthgilmour Not sure if Instil is offering Arrow trainings and would like to also be featured here in a dropdown link menu.
  • Rearranges menus in core, fx and optics to be consitent.
  • Adds link to suspend () -> A in types in Fx pointing to IO removal docs in favor of suspend

@raulraja raulraja changed the title Menu changes preparing for content specific to 1.0 CU-9rrjbq Menu changes preparing for content specific to 1.0 Feb 6, 2021
@franciscodr
Copy link
Contributor

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A couple entries for Arrow Fx can be removed due to deprecation. I only reviewed the content for the website. I'm not very familiar with Jekyll or JS.

@@ -40,27 +36,10 @@ options:
- title: Semaphore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot add multiline suggestions for code that wasn't modified it seems.

ConcurrrentVar, Promise & Semaphore are deprecated in favor of KotlinX versions of these data types. KotlinX has the following types with the same semantics: Channel(), CompletableDeferred() and Semaphore(..).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nomisRev !!

@rachelcarmena rachelcarmena merged commit 8941634 into master Feb 9, 2021
@rachelcarmena rachelcarmena deleted the rr-docs-review branch February 9, 2021 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants