Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow, setup author, and bump Gradle #11

Merged
merged 6 commits into from
Feb 14, 2023
Merged

Add workflow, setup author, and bump Gradle #11

merged 6 commits into from
Feb 14, 2023

Conversation

nomisRev
Copy link
Member

Run knitCheck and test on CI to verify correctness of docs on: pull_request.

Co-authored-by: Juan Valencia <juanvalencia@calvellido.es>
.gitignore Outdated Show resolved Hide resolved
- name: build
uses: gradle/gradle-build-action@v2
with:
arguments: build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calvellido We might want to add another step to check if the site is built correctly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great! I was not sure which commands that would involve, so I am going to leave that to @calvellido but let's do that in a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments

@nomisRev nomisRev merged commit 9e00144 into main Feb 14, 2023
@nomisRev nomisRev deleted the add-workflow branch February 14, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants