Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for Arrow Analysis #41

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Docs for Arrow Analysis #41

merged 4 commits into from
Mar 6, 2023

Conversation

serras
Copy link
Member

@serras serras commented Feb 27, 2023

These have been copied from the old website

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't proof read this since it's all already been reviewed on the analysis website. I think there is a problem with the nesting of the sidebar though.

If I click incubation then the page crashes.
Screenshot 2023-03-02 at 14 01 07
Screenshot 2023-03-02 at 14 02 26

Comment on lines +13 to +20
```kotlin
import arrow.analysis.pre

fun increment(x: Int): Int {
pre(x > 0) { "value must be positive" }
return x + 1
}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we setup KotlinX Knit for this?

Comment on lines +36 to +39
```plain
e: pre-condition `value must be positive` is not satisfied in `increment(-1)`
-> unsatisfiable constraint: `(-1 > 0)`
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could even setup KotlinX Knit for this, given that this is testable in a unit test.
If you're interested in that, I'd be happy to setup a Knit Test Template.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we check the output of the compiler using Knit?

@serras
Copy link
Member Author

serras commented Mar 2, 2023

@nomisRev Weird, I cannot reproduce the problem in my machine. What are the steps you've taken to crash?

@nomisRev
Copy link
Member

nomisRev commented Mar 2, 2023

  1. From the homepage -> drop down Incubation -> select Analysis.
  2. On analysis page click on incubation in the left sidebar.

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported issue not reproducible by @serras. Let's test it again at a later time, perhaps an issue in my local environment.

@serras serras merged commit 505c4fa into main Mar 6, 2023
@serras serras deleted the analysis branch March 6, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants