Resilience #56
Merged
Resilience #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serras
commented
Mar 6, 2023
•
serras
commented
- Intro
- Schedule
- CircuitBreaker
- Saga
franciscodr
reviewed
Mar 7, 2023
franciscodr
reviewed
Mar 7, 2023
franciscodr
reviewed
Mar 7, 2023
| @ExperimentalTime | ||
| fun <A> complexPolicy(): Schedule<A, List<A>> = | ||
| Schedule.exponential<A>(10.milliseconds).whileOutput { it < 60.seconds } | ||
| .andThen(Schedule.spaced<A>(60.seconds) and Schedule.recurs(100)).jittered() |
There was a problem hiding this comment.
Should we mention what jittered does?
There was a problem hiding this comment.
Added a line, I hadn't realized it was there
franciscodr
reviewed
Mar 7, 2023
Comment on lines
193
to
195
| Schedule.doWhile<Int>{ it <= 5 }.repeat { | ||
| counter++ | ||
| } |
There was a problem hiding this comment.
This example may confuse some people because they could think the predicate is applied over the counter. What do you think? Would it be worth mentioning that it refers to the number of iterations? 0 to 5 plus the first successful execution?
franciscodr
reviewed
Mar 7, 2023
franciscodr
reviewed
Mar 7, 2023
franciscodr
reviewed
Mar 7, 2023
franciscodr
reviewed
Mar 7, 2023
| After that, whenever more than two requests fail with an exception, | ||
| the circuit breaker starts short-circuiting failing-fast. | ||
|
|
||
| A new instance of `CircuitBreaker` is created using [`of`](https://arrow-kt.github.io/arrow/arrow-fx-resilience/arrow.fx.resilience/-circuit-breaker/-companion/of.html); there we specify |
There was a problem hiding this comment.
The of builder has been deprecated since Arrow 1.2 in favor of the class constructor
Co-authored-by: Francisco Diaz <francisco.d@47deg.com>
Co-authored-by: Francisco Diaz <francisco.d@47deg.com>
Co-authored-by: Francisco Diaz <francisco.d@47deg.com>
Co-authored-by: Francisco Diaz <francisco.d@47deg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.