Add Training page #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvellido
requested review from
serras,
anamariamv,
franciscodr,
israelperezglez and
nomisRev
|
I like the style, but I'm a bit worried about the Training page, since right now there's only one training available. |
|
Since my remark was about content and not so much about structure, I'm going to move on and merge this, so we can keep working on the content. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the Training page according to the proposed design.
As part of it, it includes:
Hero,SimpleCard,ImageCard, andBorderlessCardcomponents. Mostly for all of them to add more parameters and behaviours, to make them more powerful to show different type of data and content.And additionally, it adds less placeholdered pages for Libraries, Support, and Events pages.