Add sequence birecursive instance and fix corecursive tests #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also moved elgot and coelgot, it was a mistake to have them in recursive/corecursive. |
It wrongly used a non-monadic unfold
pakoito
reviewed
Oct 28, 2019
| @@ -0,0 +1,56 @@ | |||
| package arrow.recursion | |||
There was a problem hiding this comment.
Add Test to the name of this file, if possible :D
Should be done 👍 |
|
All ABOOOOOARD! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot this instance, also corecursive equality of unfolds by == instead of using Eq, that only fails with Sequence, but should be fixed by using equalUnderTheLaw anyway. (The same is not necessary for Recursive because we are only comparing ints there)