Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-fb0myr Remove deprecated code #2308

Merged
merged 3 commits into from Mar 10, 2021

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Mar 8, 2021

This PR removes all the remaining @Deprecated code, beside the one introduced in 0.13.0 for making mapN top-level.

@nomisRev nomisRev added the 0.13.0 label Mar 8, 2021
@nomisRev nomisRev requested a review from a team March 8, 2021 11:56
@franciscodr
Copy link
Collaborator

Task linked: CU-fb0myr Remove remaining deprecated code

@nomisRev nomisRev changed the base branch from master to release/0.13.0 March 8, 2021 13:01
Copy link
Member

@i-walker i-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@@ -92,13 +91,7 @@ abstract class AbstractProcessor : KotlinAbstractProcessor(), ProcessorUtils, Ko
else -> knownError("Unsupported @documented $kind")
}

private fun processDocs(roundEnv: RoundEnvironment): Unit =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this on purpose? If so, wouldn't be possible to delete the entire class instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on purpose. The Docs feature is no longer supported, but the AbstractProcessor is still in use until kapt for Optics is replaced by Arrow Meta.

@nomisRev nomisRev merged commit cd8d1a4 into release/0.13.0 Mar 10, 2021
@nomisRev nomisRev deleted the cu-fb0myr-remove-deprecated-code branch March 10, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants