CU-fb50p3 - Clean up Traverse API #2310

danimontoya · 2021-03-08T18:36:26Z

Clean up Traverse API:

flatTraverse
flatTraverseEither
flatTraverseValidated
travserse_
travserEither_
traverseValidated_
sequence_
sequenceEither_
sequenceValidated_
traverseFilter
traverseFilterEither

- flatTraverse - flatTraverseEither - flatTraverseValidated - travserse_ - travserEither_ - traverseValidated_ - sequence_ - sequenceEither_ - sequenceValidated_

franciscodr · 2021-03-08T18:36:27Z

Task linked: CU-fb50p3 Clean up Traverse API

…ceValidated_

…averseFilter, traverseFilterEither, traverseFilterValidated, traverseFilterIsInstance, traverseFilterIsInstanceEither, traverseFilterIsInstanceValidated

nomisRev

@danimontoya we need to compare with 0.11.0 since most of the methods deprecated here can be removed. They were all added newly on master only.

nomisRev · 2021-03-10T09:06:41Z

arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Ior.kt

+  @Deprecated(TraverseDeprecation)
  inline fun <C> traverse_(fa: (B) -> Iterable<C>): List<Unit> =
    fold({ emptyList() }, { fa(it).void() }, { _, b -> fa(b).void() })

+  @Deprecated(TraverseDeprecation)
  inline fun <AA, C> traverseEither_(fa: (B) -> Either<AA, C>): Either<AA, Unit> =
    fold({ Either.right(Unit) }, { fa(it).void() }, { _, b -> fa(b).void() })

+  @Deprecated(TraverseDeprecation)
  inline fun <AA, C> traverseValidated_(fa: (B) -> Validated<AA, C>): Validated<AA, Unit> =
    fold({ Valid(Unit) }, { fa(it).void() }, { _, b -> fa(b).void() })


These can all be deleted, they didn't exist yet on 0.11.0

nomisRev · 2021-03-10T09:06:56Z

arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Ior.kt

+@Deprecated(TraverseDeprecation)
 fun <A, B> Ior<A, Iterable<B>>.sequence_(): List<Unit> =
  traverse_(::identity)

+@Deprecated(TraverseDeprecation)
 fun <A, B, C> Ior<A, Either<B, C>>.sequenceEither_(): Either<B, Unit> =
  traverseEither_(::identity)

+@Deprecated(TraverseDeprecation)
 fun <A, B, C> Ior<A, Validated<B, C>>.sequenceValidated_(): Validated<B, Unit> =
  traverseValidated_(::identity)


These can all be deleted, they didn't exist yet on 0.11.0

nomisRev · 2021-03-10T09:07:16Z

arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Ior.kt

+@Deprecated(TraverseDeprecation)
 inline fun <A, B, C> Ior<A, B>.flatTraverse(SA: Semigroup<A>, f: (B) -> Iterable<Ior<A, C>>): List<Ior<A, C>> =
  traverse(f).map { it.flatten(SA) }

+@Deprecated(TraverseDeprecation)
 inline fun <A, B, C, E> Ior<A, B>.flatTraverseEither(SA: Semigroup<A>, f: (B) -> Either<E, Ior<A, C>>): Either<E, Ior<A, C>> =
  traverseEither(f).map { it.flatten(SA) }

+@Deprecated(TraverseDeprecation)
 inline fun <A, B, C, E> Ior<A, B>.flatTraverseValidated(SA: Semigroup<A>, f: (B) -> Validated<E, Ior<A, C>>): Validated<E, Ior<A, C>> =
  traverseValidated(f).map { it.flatten(SA) }



These can all be deleted, they didn't exist yet on 0.11.0

nomisRev · 2021-03-10T09:07:28Z

arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Iterable.kt

+@Deprecated(TraverseDeprecation)
 inline fun <E, A, B> Iterable<A>.flatTraverseEither(f: (A) -> Either<E, Iterable<B>>): Either<E, List<B>> =
  foldRight<A, Either<E, List<B>>>(emptyList<B>().right()) { a, acc ->
    f(a).ap(acc.map { bs -> { b: Iterable<B> -> b + bs } })
  }


…rseValidated_, flatSequenceValidated, sequenceValidated_

nomisRev · 2021-03-11T07:19:41Z

arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/NonEmptyList.kt

@@ -526,11 +527,13 @@ inline fun <E, A, B> NonEmptyList<A>.traverseEither(f: (A) -> Either<E, B>): Eit
    f(a).ap(acc.map { bs -> { b: B -> NonEmptyList(b) + bs } })
  }

+@Deprecated(TraverseDeprecation)


All of these didn't exist for NonEmptyList on 0.11.0 so can be removed.
https://github.com/arrow-kt/arrow-core/blob/0.11.0/arrow-core-data/src/main/kotlin/arrow/core/NonEmptyList.kt

nomisRev · 2021-03-11T07:20:08Z

arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Option.kt

@@ -749,18 +743,21 @@ sealed class Option<out A> : OptionOf<A> {
      is None -> null
    }

+  @Deprecated(TraverseDeprecation)


Idem for this file.

https://github.com/arrow-kt/arrow-core/blob/0.11.0/arrow-core-data/src/main/kotlin/arrow/core/Option.kt

nomisRev · 2021-03-11T07:21:08Z

arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Sequence.kt

@@ -108,11 +109,13 @@ fun <E, A> Sequence<Either<E, Sequence<A>>>.flatSequenceEither(): Either<E, Sequ
 fun <E, A> Sequence<Validated<E, Sequence<A>>>.flatSequenceValidated(semigroup: Semigroup<E>): Validated<E, Sequence<A>> =
  flatTraverseValidated(semigroup, ::identity)

+@Deprecated(TraverseDeprecation)


Idem for these, since this file doesn't exist in 0.11.0 so we can simply remove them all.

nomisRev · 2021-03-11T07:21:34Z

arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Validated.kt

@@ -791,6 +792,7 @@ sealed class Validated<out E, out A> : ValidatedOf<E, A> {
  inline fun <B> traverse(fa: (A) -> Iterable<B>): List<Validated<E, B>> =
    fold({ emptyList() }, { a -> fa(a).map { Valid(it) } })

+  @Deprecated(TraverseDeprecation)


Idem for all functions in this file: https://github.com/arrow-kt/arrow-core/blob/0.11.0/arrow-core-data/src/main/kotlin/arrow/core/Validated.kt

nomisRev · 2021-03-11T07:21:53Z

arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/map.kt

@@ -23,11 +24,13 @@ inline fun <K, E, A, B> Map<K, A>.traverseEither(f: (A) -> Either<E, B>): Either
    f(a).ap(acc.map { bs: Map<K, B> -> { b: B -> mapOf(k to b) + bs } })
  }

+@Deprecated(TraverseDeprecation)


None of these methods existed so can all be removed safely.

# Conflicts: # arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Option.kt

nomisRev

Thank you @danimontoya for the PR 👏 👏

raulraja

Thanks @danimontoya !

Update deprecation messages for Traverse API:

951798e

- flatTraverse - flatTraverseEither - flatTraverseValidated - travserse_ - travserEither_ - traverseValidated_ - sequence_ - sequenceEither_ - sequenceValidated_

danimontoya requested a review from nomisRev March 8, 2021 18:36

danimontoya added 3 commits March 9, 2021 09:47

Remove from Either: travserse_, traverseValidated_, sequence_, sequen…

e1ef4e8

…ceValidated_

Remove from Option: filterEither, filterIterable, filterValidated, tr…

68f584b

…averseFilter, traverseFilterEither, traverseFilterValidated, traverseFilterIsInstance, traverseFilterIsInstanceEither, traverseFilterIsInstanceValidated

revert one minor change

7371448

danimontoya marked this pull request as ready for review March 9, 2021 09:07

danimontoya requested review from franciscodr, i-walker and raulraja March 9, 2021 15:09

danimontoya added the 0.12.0 label Mar 9, 2021

nomisRev requested changes Mar 10, 2021

View reviewed changes

danimontoya added 5 commits March 10, 2021 12:55

Merge branch 'master' into dm-cleanup-traverse

1d85c8f

Remove fun's that were not existing in 0.11.0

5ec8796

Remove unused import

0dc54eb

Remove traverseEither_, sequenceEither_, flatTraverseValidated, trave…

5bebb23

…rseValidated_, flatSequenceValidated, sequenceValidated_

Some more deprecations

0c41cc6

danimontoya requested a review from nomisRev March 10, 2021 15:16

nomisRev reviewed Mar 11, 2021

View reviewed changes

danimontoya added 6 commits March 11, 2021 10:11

Remove fun's in NonEmptyList

7dc70f8

Remove fun's in Option

08076ba

Remove fun's in Sequence and Validated

0251b61

Remove fun's in map

b8cc99d

Merge branch 'master' into dm-cleanup-traverse

026409b

# Conflicts: # arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Option.kt

Ktlint

513c301

danimontoya requested a review from nomisRev March 11, 2021 09:23

nomisRev approved these changes Mar 11, 2021

View reviewed changes

raulraja approved these changes Mar 11, 2021

View reviewed changes

Merge branch 'master' into dm-cleanup-traverse

0ceabeb

nomisRev merged commit c04cdb5 into master Mar 11, 2021

nomisRev deleted the dm-cleanup-traverse branch March 11, 2021 13:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CU-fb50p3 - Clean up Traverse API #2310

CU-fb50p3 - Clean up Traverse API #2310

danimontoya commented Mar 8, 2021 •

edited

franciscodr commented Mar 8, 2021

nomisRev left a comment

nomisRev Mar 10, 2021

nomisRev Mar 10, 2021

nomisRev Mar 10, 2021

nomisRev Mar 10, 2021

nomisRev Mar 11, 2021

nomisRev Mar 11, 2021

nomisRev Mar 11, 2021

nomisRev Mar 11, 2021

nomisRev Mar 11, 2021

nomisRev left a comment

raulraja left a comment

CU-fb50p3 - Clean up Traverse API #2310

CU-fb50p3 - Clean up Traverse API #2310

Conversation

danimontoya commented Mar 8, 2021 • edited

franciscodr commented Mar 8, 2021

nomisRev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nomisRev left a comment

Choose a reason for hiding this comment

raulraja left a comment

Choose a reason for hiding this comment

danimontoya commented Mar 8, 2021 •

edited