CU-fb532c - Clean up Selective api #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-fb532c Clean up Selective API |
nomisRev
reviewed
Mar 10, 2021
| @@ -1,155 +0,0 @@ | |||
| package arrow.core.extensions.option.selective | |||
There was a problem hiding this comment.
All thse files XXXSelective.kt in extensions have to stay until the deprecation cycle has finished in 0.13.0
| @@ -43,7 +41,6 @@ object MonadLaws { | |||
| M: Monad<F>, | |||
| FF: Functor<F>, | |||
| AP: Apply<F>, | |||
| SL: Selective<F>, | |||
There was a problem hiding this comment.
These changes are unnecessary since we keep Selective around until fully deprecated and removed in 0.13.0.
nomisRev
reviewed
Mar 11, 2021
| fun <E> Validated<E, Boolean>.orS(f: Validated<E, Boolean>): Validated<E, Boolean> = | ||
| ifS(Valid(true), f) | ||
|
|
||
| @Deprecated(SelectiveDeprecation) | ||
| fun <E> Validated<E, Boolean>.andS(f: Validated<E, Boolean>): Validated<E, Boolean> = | ||
| ifS(f, Valid(false)) |
There was a problem hiding this comment.
All these methods didn't exist in 0.11.0 and can therefore be removed.
https://github.com/arrow-kt/arrow-core/blob/0.11.0/arrow-core-data/src/main/kotlin/arrow/core/Validated.kt
| fun <A, B> Option<Either<A, B>>.select(f: OptionOf<(A) -> B>): Option<B> = | ||
| branch(f.fix(), Some(::identity)) | ||
|
|
||
| @Deprecated(SelectiveDeprecation) |
There was a problem hiding this comment.
branch doesn't seem to exist for 0.11.0
# Conflicts: # arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Option.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://app.clickup.com/t/fb532c
Remove/deprecate Selective API