Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typeclasses docs #2313

Merged
merged 4 commits into from Mar 9, 2021
Merged

Conversation

aballano
Copy link
Member

@aballano aballano commented Mar 9, 2021

Adapt Monoid, Semigroup and Semiring docs to the new typeclass syntax

Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @aballano !

arrow-docs/docs/arrow/typeclasses/monoid/README.md Outdated Show resolved Hide resolved
@@ -11,7 +9,8 @@ interface Semigroup<A> {
operator fun A.plus(b: A): A =
this.combine(b)

fun A.maybeCombine(b: A?): A = Option.fromNullable(b).fold({ this }, { combine(it) })
fun A.maybeCombine(b: A?): A =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raulraja raulraja requested a review from a team March 9, 2021 15:43
@aballano
Copy link
Member Author

aballano commented Mar 9, 2021

This contributes to CU-9rrjbq

Copy link
Member

@i-walker i-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aballano 🙌🏾

@i-walker i-walker merged commit 525f4a0 into release/0.12.0 Mar 9, 2021
@i-walker i-walker deleted the ab/update-typeclasses-docs branch March 9, 2021 16:37
@rachelcarmena rachelcarmena restored the ab/update-typeclasses-docs branch March 10, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants