Replace mapN with zip #2315
Merged
Replace mapN with zip #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-fb4p28 Replace mapN with zip |
raulraja
reviewed
Mar 9, 2021
| i: Either<A, I>, | ||
| map: (B, C, D, E, F, G, H, I) -> J | ||
| ): Either<A, J> = | ||
| zip(c, d, e, f, g, h, i, Either.unit, Either.unit) { b, c, d, e, f, g, h, i, _, _ -> map(b, c, d, e, f, g, h, i) } |
There was a problem hiding this comment.
just realized we have Either.unit vs Eval.Unit
There was a problem hiding this comment.
Either.unit is internal and Eval.Unit is deprecated ;)
raulraja
approved these changes
Mar 9, 2021
nomisRev
commented
Mar 10, 2021
Comment on lines
+257
to
+269
| * When working with `NonEmptyList` in the `Invalid` side, there is no need to supply `Semigroup` as shown in the example above. | ||
| * | ||
| * ```kotlin:ank:silent | ||
| * import arrow.core.Validated | ||
| * import arrow.core.validNel | ||
| * import arrow.core.zip | ||
| * | ||
| * //sampleStart | ||
| * val parallelValidate = | ||
| * 1.validNel().zip(2.validNel()) | ||
| * { a, b -> /* combine the result */ } | ||
| * //sampleEnd | ||
| * ``` |
i-walker
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in Arrow we have
mapNfromApply. This PR proposes to replace it in Arrow withzip, which is more in line with the Kotlin Std.For example the Kotlin Std exposes
ziparity 2 forIterableand instead of duplicatingzipwithmapNand providing up to arity 10 we can now just extend the Kotlin Std API and expose arity 3-10 forIterable#zip. Doing so we clearly complement the Kotlin Std instead of proposing alternative APIs.It also prevents us from having to do 2 deprecation cycles, and will result in a
@Deprecatedfree library @0.13.0.This PR also removes all
Nbased APIs by also replacingparMapNin Arrow Fx Coroutines withparZip.