Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU-fb6x32 Clean up Arrow Syntax based on API Review #2330

Merged
merged 22 commits into from Mar 22, 2021
Merged

CU-fb6x32 Clean up Arrow Syntax based on API Review #2330

merged 22 commits into from Mar 22, 2021

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Mar 17, 2021 •
edited

  • Remove Ior.unit
  • Remove Validated.s
  • Remove SetKZip instance
  • Remove foldMapA
  • Remove ifM
  • Remove zipEval
  • Remove selectM
  • Remove fproduct/tupleLeft/tupleRight/mproduct
  • ap/apEval
  • Deprecate tailRecM
  • Update deprecations AndThen

@nomisRev nomisRev requested a review from a team March 17, 2021 15:46
@franciscodr
Copy link
Collaborator

Task linked: CU-fv6x32 Clean-up Arrow Core after API Review

@nomisRev nomisRev changed the title Apply API review comments CU-fb6x32 Clean up Arrow Syntax based on API Review Mar 18, 2021
raulraja
raulraja reviewed Mar 19, 2021
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nomisRev looking great! thanks 🙏

arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/AndThen.kt Outdated Show resolved Hide resolved
arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Either.kt Show resolved Hide resolved
arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Nullable.kt Outdated Show resolved Hide resolved
arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/predef.kt Outdated Show resolved Hide resolved
arrow-libs/core/arrow-core-data/src/test/kotlin/arrow/core/IterableTest.kt Outdated Show resolved Hide resolved
arrow-libs/core/arrow-core/src/main/kotlin/arrow/core/extensions/ior/monad/IorMonad.kt Outdated Show resolved Hide resolved
arrow-libs/core/arrow-core/src/main/kotlin/arrow/core/extensions/list/apply/ListKApply.kt Show resolved Hide resolved
arrow-libs/core/arrow-core/src/main/kotlin/arrow/core/extensions/list/apply/ListKApply.kt Show resolved Hide resolved
arrow-libs/core/arrow-core/src/main/kotlin/arrow/core/extensions/list/monad/ListKMonad.kt Show resolved Hide resolved
arrow-libs/core/arrow-core/src/main/kotlin/arrow/core/extensions/option/apply/OptionApply.kt Show resolved Hide resolved
nomisRev and others added 8 commits March 19, 2021 16:03
@nomisRev
Fix build
b558bb5
@nomisRev @raulraja
Apply suggestions from code review
5eee674 
Co-authored-by: Raúl Raja Martínez <raulraja@gmail.com>
@nomisRev @raulraja
Update arrow-libs/core/arrow-core/src/main/kotlin/arrow/core/extensio…
1428167 
…ns/ior/apply/IorApply.kt

Co-authored-by: Raúl Raja Martínez <raulraja@gmail.com>
@nomisRev @raulraja
Update arrow-libs/core/arrow-core/src/main/kotlin/arrow/core/extensio…
3263c84 
…ns/ior/monad/IorMonad.kt

Co-authored-by: Raúl Raja Martínez <raulraja@gmail.com>
@nomisRev @raulraja
Update arrow-libs/core/arrow-core/src/main/kotlin/arrow/core/extensio…
991ea88 
…ns/ior/monad/IorMonad.kt

Co-authored-by: Raúl Raja Martínez <raulraja@gmail.com>
@nomisRev @raulraja
Update arrow-libs/core/arrow-core/src/main/kotlin/arrow/core/extensio…
83debc3 
…ns/ior/monad/IorMonad.kt

Co-authored-by: Raúl Raja Martínez <raulraja@gmail.com>
@nomisRev
Apply review suggestions, and fix build
7e9f754
@nomisRev
Merge branch 'cu-fv6x32-clean-up-arrow-core-review' of github.com:arr…
7d56e6a 
…ow-kt/arrow into cu-fv6x32-clean-up-arrow-core-review
@nomisRev nomisRev marked this pull request as ready for review March 22, 2021 10:42
@nomisRev nomisRev requested a review from a team March 22, 2021 10:42
raulraja
raulraja approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nomisRev 🙏

i-walker
i-walker reviewed Mar 22, 2021
View reviewed changes
arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Iterable.kt
inline fun <E, A, B> Iterable<A>.traverseEither(f: (A) -> Either<E, B>): Either<E, List<B>> =
foldRight<A, Either<E, List<B>>>(emptyList<B>().right()) { a, acc ->
f(a).ap(acc.map { bs -> { b: B -> listOf(b) + bs } })
when (val res = f(a)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏾

i-walker
i-walker approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@i-walker i-walker left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my longest review of the week 😄
Thanks for the work @nomisRev 🙌🏾

@nomisRev nomisRev merged commit f3b99cd into master Mar 22, 2021
@nomisRev nomisRev deleted the cu-fv6x32-clean-up-arrow-core-review branch March 22, 2021 23:02
@nomisRev nomisRev mentioned this pull request Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

@i-walker i-walker i-walker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nomisRev @franciscodr @raulraja @i-walker