Bring kategory-annotations to the kategory repo
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of instances bugs
raulraja
changed the title
kategory-annotations to the kategory repokategory-annotations to the kategory repo
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
=========================================
Coverage ? 41.74%
Complexity ? 259
=========================================
Files ? 136
Lines ? 3145
Branches ? 410
=========================================
Hits ? 1313
Misses ? 1706
Partials ? 126
Continue to review full report at Codecov.
|
pakoito
reviewed
Sep 8, 2017
| @@ -8,29 +8,7 @@ import io.kotlintest.specs.StringSpec | |||
| * Base class for unit tests | |||
| */ | |||
| abstract class UnitSpec : StringSpec() { | |||
| companion object { | |||
raulraja
changed the title
kategory-annotations to the kategory repokategory-annotations to the kategory repo
pakoito
reviewed
Sep 8, 2017
| @@ -78,7 +80,7 @@ formatting: | |||
| active: true | |||
| autoCorrect: true | |||
| OptionalUnit: | |||
| active: true | |||
| active: false | |||
There was a problem hiding this comment.
Ideally we'd need the opposite option: flagging places where Unit isn't there. For us explicitness is key and we've been bitten by returns that should be Unit instead before.
There was a problem hiding this comment.
Agreed, If detekt rules can be user created we can also provide some to encourage a more functional style.
pakoito
approved these changes
Sep 8, 2017
aballano
approved these changes
Sep 8, 2017
tonilopezmr
approved these changes
Sep 8, 2017
| @@ -59,17 +59,17 @@ data class ListKW<out A> constructor(val list: List<A>) : ListKWKind<A>, List<A> | |||
| return ListKW(buf) | |||
| } | |||
|
|
|||
| fun functor(): ListKWHKMonadInstance = ListKW.monad() | |||
| fun functor(): ListKWMonadInstance = ListKW.monad() | |||
There was a problem hiding this comment.
Why haven't you deleted these methods like in Id or NonEmptyList?
There was a problem hiding this comment.
I though I did, but will look over before merging
nomisRev
approved these changes
Sep 8, 2017
Closed
rachelcarmena
pushed a commit
that referenced
this pull request
Feb 24, 2021
rachelcarmena
added a commit
that referenced
this pull request
Feb 24, 2021
* Makes DelimContScope#reset suspend * Add suspending tests to TestSuite * Move result to promise as well. Fixes suspension in shift before immediate return * Update MultiShotCont with new impl * Entry point api functions * ktLintFormat * Fix `suspended` in `FxLaws` doesn't actually suspend * Re-add eager versions, fix `RestrictSuspension` in `nullable` and add suspend version * Test that shows flow comprehension hanging * Adds Stream test that also hangs * Remove multi-shot test demos * Effect interface and computation builder * Rename Effect to computations * Disable ktlint in effect file * Correct suspension requires ControlThrowable * Upgrade ktlint to allow fun interfaces * Fix support for nested scopes, add tests for not leaking Arrow Fx & KotlinX Coroutines * Removes NestedDelimContScope, makes Multishot private until we have a compiler plugin solution for ordered binds. Prepares DelimitedScope to be implemented by all and SuspendingComputation to replace DelimContScope if it's possible to implement its shift on it * unfinished progress to share with Simon * Add docs, revert some changes for RestrictSuspension implementation. Keep shiftCPS internally * progress toward encoding effects with suspend an restricted delimited scopes * tests passing * remove runRestrictedSuspension * Fix ktlintMainSourceSetCheck issues * Fix ktlintTestSourceSetCheck issues * Fix ktlint issues for arrow-core-data * Adapted Fx laws, test failing with suspension * ktlint * fix for Fx laws * Remove BindSyntax leftover for nullable * Remove old destructuring syntax for bind from Either doc * Raquel suggestion Co-authored-by: Rachel M. Carmena <rachelcarmena@users.noreply.github.com> * Deprecate `validated` block in favor of `either` block. * Deprecate Validated fx * Either.toValidated/Nel + fix to Validated docs * ktlint fixes Co-authored-by: Simon Vergauwen <vergauwen.simon@gmail.com> Co-authored-by: Rachel M. Carmena <rachelcarmena@users.noreply.github.com> Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a bunch of instances issues and provides some
implicitobjects where instances can be looked up without the need to manually register anything.kategory-annotationsmigrations@derivingdatatypes (will be addresed in Add all possible implicit objects to manual instances #260)