Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prism processor #267

Merged
merged 3 commits into from
Sep 11, 2017
Merged

Prism processor #267

merged 3 commits into from
Sep 11, 2017

Conversation

nomisRev
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@b63e270). Click here to learn what that means.
The diff coverage is 11.59%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #267   +/-   ##
=========================================
  Coverage          ?   41.79%           
  Complexity        ?      277           
=========================================
  Files             ?      141           
  Lines             ?     3254           
  Branches          ?      405           
=========================================
  Hits              ?     1360           
  Misses            ?     1768           
  Partials          ?      126
Impacted Files Coverage Δ Complexity Δ
...ory-test/src/main/kotlin/kategory/laws/LensLaws.kt 54.28% <ø> (ø) 7 <0> (?)
...ry-test/src/main/kotlin/kategory/laws/PrismLaws.kt 59.25% <ø> (ø) 6 <0> (?)
...or/src/main/java/kategory/optics/AnnotationInfo.kt 0% <ø> (ø) 0 <0> (?)
...ory-optics/src/main/kotlin/kategory/optics/Lens.kt 69.44% <0%> (ø) 6 <0> (?)
...c/main/java/kategory/optics/PrismsFileGenerator.kt 0% <0%> (ø) 0 <0> (?)
...r/src/main/java/kategory/optics/AnnotatedDomain.kt 0% <0%> (ø) 0 <0> (?)
...r/src/main/java/kategory/optics/OpticsProcessor.kt 0% <0%> (ø) 0 <0> (?)
...c/main/java/kategory/optics/LensesFileGenerator.kt 0% <0%> (ø) 0 <0> (?)
...ry-optics/src/main/kotlin/kategory/optics/Prism.kt 72.34% <66.66%> (ø) 11 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b63e270...84157ea. Read the comment docs.

Copy link
Member

@pakoito pakoito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been asking about prism-like constructs since forever. Happy they're finally here!

@nomisRev
Copy link
Member Author

And much more will come very soon 👍

@nomisRev nomisRev merged commit 6da6d8c into arrow-kt:master Sep 11, 2017
@wiyarmir wiyarmir mentioned this pull request Sep 15, 2017
rachelcarmena added a commit that referenced this pull request Feb 24, 2021
…mplementations (#267)

* Remove @higherkind generation, and deprecate generated code

* Remove @extensions for Validated Eq

* Deprecate @extension and add missing concrete implementations

* Add show on Companion of Validated

* Add order on Companion of Validated

* Remove dummy params from product

* Add deprecation to last methods

* Rewrite Validated branch

* Fix concrete bifoldable signatures

* ktlintFormat & fix docs

* Revert refactor from suspend Validated.catch to inline Validated.catch

* ktlintFormat

* Revert refactor from suspend Validated.catch to inline Validated.catch

* Fix incorrect import

* Add missing , in Validated docs

* Validated.kt doc fromOption -> fromNullable

* Docs green locally

* Re-add `unit` and make `DeprecatedLevel.ERROR`

* Remove TupleN from mapN signature

* Revert "Re-add `unit` and make `DeprecatedLevel.ERROR`, not possible due to @extensions"

This reverts commit c540118a09cbbb5e7cbef9566b9465e8bccc8138.

* ktlintFormat

* Fix Validated.mapN docs

* Retrigger build

* Update type arguments names, and param names

* Replace suspend catch with inline catch while maintaining binary compat

Co-authored-by: Rachel M. Carmena <rachelcarmena@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants