Use new Atomic types from Kotlin 1.9 #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kover Report
|
nomisRev
approved these changes
Oct 19, 2023
nomisRev
reviewed
Oct 19, 2023
| @@ -119,10 +119,12 @@ class RaceNJvmTest : StringSpec({ | |||
| } | |||
| } | |||
|
|
|||
| /* This seems to not be true anymore | |||
There was a problem hiding this comment.
🤯, really!?
I guess we want to stick to what select does 🤔
There was a problem hiding this comment.
It's been flaky in the last few versions...
There was a problem hiding this comment.
Strange, do you know with what assertion error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin Native 1.9 introduced a new
kotlin.concurrentmodule that replaceskotlin.native.concurrent. The deprecation period is small, and in 2.0 thekotlin.native.concurrentversions are already gone. Since we're already building with 1.9.10, changing feels safe.This PR is needed to keep checking that we work OK with newer
devversions of Kotlin.