Safeguard for leaked 'raise' or 'bind' #3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kover Report
|
nomisRev
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Oh, I really love this!! 😍 Thanks @serras, love this addition.
It would be great to also detect Deferred or Flow from kotlinx.coroutines, but this doesn't seem like a good enough reason to add a dependency on those.
Totally agree. Still wondering if this could be generalised, and if it could be useful to have in the language as an annotation similar to @RestrictSuspension but in relation to escaping of operations in DSLs. That probably opens another can of worms 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be accompanied with a text in the Arrow docs.
It would be great to also detect
DeferredorFlowfromkotlinx.coroutines, but this doesn't seem like a good enough reason to add a dependency on those.