Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OptionT as HK2 #52

Merged
merged 2 commits into from Mar 29, 2017
Merged

Conversation

ffgiraldez
Copy link
Member

use tipealias for HKX

@codecov
Copy link

codecov bot commented Mar 29, 2017

Codecov Report

❗ No coverage uploaded for pull request base (rr-option-transformer@4668a9e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             rr-option-transformer   #52   +/-   ##
=====================================================
  Coverage                         ?    0%           
=====================================================
  Files                            ?     1           
  Lines                            ?     2           
  Branches                         ?     0           
=====================================================
  Hits                             ?     0           
  Misses                           ?     2           
  Partials                         ?     0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4668a9e...6a5b12d. Read the comment docs.

fa.ev().map(f)

override fun <A> pure(a: A): HK<Id.F, A> = Id(a)
override fun <A> pure(a: A): Id<A> = Id(a)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use HK<Id.F,A> or Id<A> which is better here and other monads?

I prefer hide as much as posible the HK hack but and only have it only as parameters and not in return types

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always take as args as generic as you can and return as concrete as you can is a good rule of thumb

fa.ev().map(f)

override fun <A> pure(a: A): HK<Id.F, A> = Id(a)
override fun <A> pure(a: A): Id<A> = Id(a)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always take as args as generic as you can and return as concrete as you can is a good rule of thumb

@raulraja raulraja merged commit 6b8762f into rr-option-transformer Mar 29, 2017
@raulraja raulraja deleted the ff-option-transformer branch March 29, 2017 09:09
ffgiraldez added a commit that referenced this pull request Apr 2, 2017
* Implement OptionT as HK2

use tipealias for HKX

* add missing methods
ffgiraldez added a commit that referenced this pull request Apr 3, 2017
* Implement OptionT as HK2

use tipealias for HKX

* add missing methods
ffgiraldez added a commit that referenced this pull request Apr 3, 2017
* Implement OptionT as HK2

use tipealias for HKX

* add missing methods
@arturogutierrez arturogutierrez mentioned this pull request Apr 7, 2017
11 tasks
dominv pushed a commit to dominv/arrow that referenced this pull request Jul 9, 2018
КТ-21795: check available kotlin version on backend side
ambrusadrianz pushed a commit to ambrusadrianz/arrow that referenced this pull request Oct 22, 2019
* add deploy

* minor improvement

* bad indent

* missing method

* delete gradle from modules

* fix missing module

* increase decoding from raw threshold
rachelcarmena added a commit that referenced this pull request Feb 24, 2021
rachelcarmena added a commit that referenced this pull request Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants