Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlin-metadata library #821

Merged
merged 6 commits into from
Apr 28, 2018
Merged

Update kotlin-metadata library #821

merged 6 commits into from
Apr 28, 2018

Conversation

Takhion
Copy link
Contributor

@Takhion Takhion commented Apr 27, 2018

The tests pass so I don't think I've broken anything 😅

It no longer depends on Kotlin compiler-embeddable! 🎉
@JorgeCastilloPrz can you take a look at this? It's split in a separate commit so it can be easily reverted, if necessary :D
@codecov
Copy link

codecov bot commented Apr 27, 2018

Codecov Report

Merging #821 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #821      +/-   ##
============================================
- Coverage     44.24%   44.23%   -0.01%     
  Complexity      625      625              
============================================
  Files           290      290              
  Lines          7420     7419       -1     
  Branches        831      830       -1     
============================================
- Hits           3283     3282       -1     
+ Misses         3838     3837       -1     
- Partials        299      300       +1
Impacted Files Coverage Δ Complexity Δ
...src/main/java/arrow/common/utils/ProcessorUtils.kt 42.52% <ø> (+0.48%) 0 <0> (ø) ⬇️
...cessor/src/main/java/arrow/renzu/RenzuProcessor.kt 79.16% <ø> (ø) 12 <0> (ø) ⬇️
...or/src/main/java/arrow/derive/DerivingProcessor.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...java/arrow/higherkinds/HigherKindsFileGenerator.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...src/main/java/arrow/instances/InstanceProcessor.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...main/java/arrow/instances/InstanceFileGenerator.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...ssor/src/main/java/arrow/optics/OpticsProcessor.kt 65.07% <ø> (ø) 23 <0> (ø) ⬇️
...rc/main/java/arrow/derive/DerivingFileGenerator.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...cessor/src/main/java/arrow/renzu/RenzuGenerator.kt 75.24% <50%> (ø) 26 <0> (ø) ⬇️
...va/arrow/common/utils/ClassOrPackageDataWrapper.kt 31.81% <50%> (ø) 0 <0> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3efcd3...55bc76d. Read the comment docs.

Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Takhion ! 👏

@raulraja
Copy link
Member

Seems like there is a cycle in the gradle tasks somewhere https://travis-ci.org/arrow-kt/arrow/builds/372231164#L729

@pakoito
Copy link
Member

pakoito commented Apr 27, 2018

The annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on

@JorgeCastilloPrz
Copy link
Member

Ok looks like we cannot depend on core there 😂. Sry for suggesting that! Can you get back to Pair then @Takhion ? That should be enough

@JorgeCastilloPrz
Copy link
Member

JorgeCastilloPrz commented Apr 28, 2018

Actually could you please just revert that commit ? I'm working on some big refactor on the processor here (which is actually finished) and in order to avoid conflicts it'd be better if I address it there or in a separate PR :).

@Takhion
Copy link
Contributor Author

Takhion commented Apr 28, 2018

@pakoito The annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on

pffft I thought you guys were good with recursion... 🙄 💁‍♂️

:trollface:

@JorgeCastilloPrz
Copy link
Member

JorgeCastilloPrz commented Apr 28, 2018

My PR has been merged now so you'll probably need to take my version of the generator as is except for anything required to adapt it to the new kotlin-metadata version

sry for the ping pong! 😅

# Conflicts:
#	modules/core/arrow-annotations-processor/src/main/java/arrow/renzu/RenzuGenerator.kt
@pakoito pakoito merged commit b390bf7 into arrow-kt:master Apr 28, 2018
@pakoito
Copy link
Member

pakoito commented Apr 28, 2018

Thanks @Takhion!!! New methods look awesome :D

@Takhion Takhion mentioned this pull request Apr 28, 2018
@akhanal
Copy link

akhanal commented May 2, 2018

Thanks @Takhion @pakoito @raulraja. This solves maven dependency not found error I was getting when trying arrow-kt. I am new to all of kotlin and arrow-kt and really appreciate @Takhion making all this effort to help after we talked.

RawToast pushed a commit to RawToast/kategory that referenced this pull request Jul 18, 2018
* Update kotlin-metadata library from 1.2.1 to 1.4.0

It no longer depends on Kotlin compiler-embeddable! 🎉

* Remove unused method (with unavailable dependency)

* Replace unavailable dependency javaslang.Tuple2 with Pair

@JorgeCastilloPrz can you take a look at this? It's split in a separate commit so it can be easily reverted, if necessary :D

* Use Tuple2 from arrow-core instead of Pair

(it's what @JorgeCastilloPrz wants!)

* Revert "Use Tuple2 from arrow-core instead of Pair"

(it's @JorgeCastilloPrz's fault :P arrow-kt#821 (comment))

This reverts commit c9e0e1f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants