-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kotlin-metadata library #821
Conversation
It no longer depends on Kotlin compiler-embeddable! 🎉
@JorgeCastilloPrz can you take a look at this? It's split in a separate commit so it can be easily reverted, if necessary :D
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
============================================
- Coverage 44.24% 44.23% -0.01%
Complexity 625 625
============================================
Files 290 290
Lines 7420 7419 -1
Branches 831 830 -1
============================================
- Hits 3283 3282 -1
+ Misses 3838 3837 -1
- Partials 299 300 +1
Continue to review full report at Codecov.
|
(it's what @JorgeCastilloPrz wants!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Takhion ! 👏
Seems like there is a cycle in the gradle tasks somewhere https://travis-ci.org/arrow-kt/arrow/builds/372231164#L729 |
The annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on the annotation processor depending on core depending on |
Ok looks like we cannot depend on core there 😂. Sry for suggesting that! Can you get back to |
Actually could you please just revert that commit ? I'm working on some big refactor on the processor here (which is actually finished) and in order to avoid conflicts it'd be better if I address it there or in a separate PR :). |
(it's @JorgeCastilloPrz's fault :P #821 (comment)) This reverts commit c9e0e1f.
pffft I thought you guys were good with recursion... 🙄 💁♂️ |
My PR has been merged now so you'll probably need to take my version of the generator as is except for anything required to adapt it to the new kotlin-metadata version sry for the ping pong! 😅 |
# Conflicts: # modules/core/arrow-annotations-processor/src/main/java/arrow/renzu/RenzuGenerator.kt
Thanks @Takhion!!! New methods look awesome :D |
* Update kotlin-metadata library from 1.2.1 to 1.4.0 It no longer depends on Kotlin compiler-embeddable! 🎉 * Remove unused method (with unavailable dependency) * Replace unavailable dependency javaslang.Tuple2 with Pair @JorgeCastilloPrz can you take a look at this? It's split in a separate commit so it can be easily reverted, if necessary :D * Use Tuple2 from arrow-core instead of Pair (it's what @JorgeCastilloPrz wants!) * Revert "Use Tuple2 from arrow-core instead of Pair" (it's @JorgeCastilloPrz's fault :P arrow-kt#821 (comment)) This reverts commit c9e0e1f.
The tests pass so I don't think I've broken anything 😅