sequenceK semigroup combine fix #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakoito
approved these changes
Jul 3, 2018
pakoito
reviewed
Jul 3, 2018
richard-gibson
force-pushed
the
sequencek_combine_fix
branch
from
da23615
to
44d1caf
Compare
|
@pakoito yeh, I started adding tests but had some problems with generators at first. added to PR for sequenceK now |
richard-gibson
force-pushed
the
sequencek_combine_fix
branch
from
44d1caf
to
48c8d88
Compare
pakoito
reviewed
Jul 3, 2018
| TraverseLaws.laws(this, this, { n: Int -> SequenceK(sequenceOf(n)) }, eq), | ||
| SemigroupKLaws.laws(this, this, eq), | ||
| MonoidLaws.laws(SequenceK.monoid(), Gen.list(Gen.int()).map{it.asSequence()}.generate().k(), eq), | ||
| SemigroupLaws.laws(SequenceK.semigroup(), |
There was a problem hiding this comment.
These are not needed, as MonoidLaws includes SemigroupLaws.
pakoito
reviewed
Jul 3, 2018
| @@ -32,7 +34,14 @@ class SequenceKTest : UnitSpec() { | |||
| ShowLaws.laws(show, eq) { sequenceOf(it).k() }, | |||
| MonadLaws.laws(this, eq), | |||
| MonoidKLaws.laws(this, this, eq), | |||
| TraverseLaws.laws(this, this, { n: Int -> SequenceK(sequenceOf(n)) }, eq) | |||
| TraverseLaws.laws(this, this, { n: Int -> SequenceK(sequenceOf(n)) }, eq), | |||
| SemigroupKLaws.laws(this, this, eq), | |||
There was a problem hiding this comment.
These are not needed, as MonoidKLaws includes SemigroupKLaws.
|
@richard-gibson one small fix and we're good to go! |
|
@pakoito no prob, do you mind if I also make SequenceKMonoidInstance inherit SequenceKSemigroupInstance so there is no duplication of combine? |
richard-gibson
force-pushed
the
sequencek_combine_fix
branch
from
48c8d88
to
9656e64
Compare
|
@richard-gibson thanks for the fix!, merging this now, feel free to submit another one to avoid duplication of |
RawToast
pushed a commit
to RawToast/kategory
that referenced
this pull request
Jul 18, 2018
* sequenceK semigroup combine fix * Add missing closing parens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.