Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More IO perf improvements #968

Merged
merged 3 commits into from Aug 2, 2018
Merged

More IO perf improvements #968

merged 3 commits into from Aug 2, 2018

Conversation

pakoito
Copy link
Member

@pakoito pakoito commented Aug 2, 2018

Optimize continueOn().continueOn() to only start the coroutine of the second one.

Make map and flatMap overriden open methods without runtime costs.

flatMapping a RaiseError yields itself

@pakoito pakoito requested review from raulraja and a team August 2, 2018 00:43
@codecov
Copy link

codecov bot commented Aug 2, 2018

Codecov Report

Merging #968 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #968      +/-   ##
============================================
- Coverage     46.71%   46.69%   -0.03%     
  Complexity      649      649              
============================================
  Files           308      308              
  Lines          8012     8008       -4     
  Branches        821      820       -1     
============================================
- Hits           3743     3739       -4     
  Misses         3939     3939              
  Partials        330      330
Impacted Files Coverage Δ Complexity Δ
.../arrow-effects/src/main/kotlin/arrow/effects/IO.kt 68.96% <66.66%> (-2.01%) 9 <2> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ed95e...ddef0ec. Read the comment docs.

@raulraja raulraja merged commit 60f0b94 into master Aug 2, 2018
@raulraja raulraja deleted the paco-moreioperf branch August 2, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants