Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding FP to the max implementation #987

Merged
merged 2 commits into from Aug 14, 2018
Merged

Adding FP to the max implementation #987

merged 2 commits into from Aug 14, 2018

Conversation

enhan
Copy link
Contributor

@enhan enhan commented Aug 14, 2018

I added the original version I wrote. I am sure we can improve it (see Raul's comment, but I don't completely understand what @raulraja means.

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #987 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #987   +/-   ##
========================================
  Coverage      46.2%   46.2%           
  Complexity      680     680           
========================================
  Files           315     315           
  Lines          7932    7932           
  Branches        826     826           
========================================
  Hits           3665    3665           
  Misses         3937    3937           
  Partials        330     330

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce41e46...ced0090. Read the comment docs.

Copy link
Member

@pakoito pakoito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it :D We can add Raul's suggestions afterwards. I have a couple more of my own, we'll just PR them directly to the new example.

@pakoito pakoito merged commit 7839164 into arrow-kt:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants