Relax dependency backports.functools-lru-cache to be >= 1.2.1 #499
Conversation
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 3189 3189
Branches 229 229
=====================================
Hits 3189 3189Continue to review full report at Codecov.
|
setup.py
Outdated
| @@ -28,7 +28,7 @@ def grep(attrname): | |||
|
|
|||
| install_requires = ['python-dateutil'] | |||
| if sys.version_info[0] < 3: | |||
| install_requires.append('backports.functools_lru_cache==1.2.1') | |||
| install_requires.append('backports.functools_lru_cache==1.4') | |||
There was a problem hiding this comment.
Would it be possible to have here backports.functools_lru_cache>=1.2.1?
There was a problem hiding this comment.
I personally don't have any issue with >= (in fact, I think less stringent bounding in general is a good thing, until a conflict is found), however all the other documented requirements are a strict ==.
I will make the change and see what the maintainer says.
The default version of backports.functools-lru-cache is now 1.4. Given the... interesting... behaviour of setuptools when calculating transitive dependencies, another package may pull in backports.functools-lru-cache 1.4, prior to evaluating arrow's need for backports.functools-lru.cache 1.2.1. I've run all the test suites in macos and linux, and backports.functools-lru-cache 1.4 works. Accordingly, I'm relaxing the requirement for backports.functools-lru-cache to be >= 1.2.1.
rtdean
force-pushed
the
fix-backports-lru-dependency
branch
from
3e069f4
to
1c7228f
Compare
rtdean
changed the title
|
Note that declaring dependencies like this via runnable code means you can run into issue when generating wheels, specifically that the code to determine your dependencies will be run when the when is generated rather than when the wheel is installed. Two solutions:
|
|
Any ETA for a release w/ this patch? |
|
@papachoco Per @MinchinWeb, I would say this patch should not be required at all, and that #504 should be accepted instead. This is the wrong way to handle conditional dependencies. |
|
Yes let's continue with #504 |
backports.functools-lru-cacheis up to version 1.4. Because of how setuptools ends up calculating transitive dependencies, if you depend on something that depends onbackports.functools-lru-cache(no version specified), and depend on something that depends onarrowthat depends onbackports.functools-lru-cache==1.2.1, you can end up with setuptools pulling inbackports.functools-lru-cacheat 1.4, and skipping/ignoring the==1.2.1requirement.This then breaks execution, as package requirements aren't satisfied.
I've run the complete test suite on both linux and macos using 1.4 (latest), with no issue. And, of course, the travis builds for this pr should pull in 1.4 as well, because of the relaxed requirements.
fixes #497