-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Massive update #6
Conversation
Fix error on comment line
Thank you for submitting this i like some of the changes your proposing like adding a theme option and possibly support for 1.3.x however to properly support 1.3.x the js would need to change as well. as far as supporting inline with a data-attribute this already worked. There are several other issues with this PR as well there are far far too many commits it adds your self as an author and while i appreciate the code cleanup it i make any code cleanup changes it will be to follow the jQuery style guide which i already filed an issue for. #7 if you would like to clean up this PR to one commit per feature added id be happy to review it in detail and see about adding some of these features |
Also please fix any merge conflicts |
Well, I fork again the project and I will send you another pull request. |
Bug fixes:
New features: