Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method getting Facebook object type #483

Merged
merged 1 commit into from Jul 8, 2016
Merged

Add method getting Facebook object type #483

merged 1 commit into from Jul 8, 2016

Conversation

sancopanco
Copy link
Contributor

No description provided.

@arronmabrey
Copy link

👍

@arsduo
Copy link
Owner

arsduo commented Sep 11, 2015

Thanks! I'll review this this weekend.

Could you please add a brief description and a link to the relevant
Facebook docs in the pull request? That'd be useful for me and other future
developers looking at the history.
On Sep 11, 2015 10:49 AM, "Arron Mabrey" notifications@github.com wrote:

[image: 👍]


Reply to this email directly or view it on GitHub
#483 (comment).

@arsduo arsduo added this to the Koala 2.4 milestone Apr 10, 2016
@arsduo
Copy link
Owner

arsduo commented Apr 10, 2016

Sorry about how long it's taken me to get to this! Thank you for submitting the PR.

What do you think of making the method get_object_metadata instead of making it specific to the type? There's a lot of other data in the metadata, and if the main purpose of the convenience method would be to shield users from having to know about the special metadata=1 argument, it seems valuable to return all of it. (Put another way, the additional complexity to get the type parameter from the metadata hash if we expose the whole thing is less than the additional complexity to get any of the other metadata fields if we only return type.)

Let me know what you think. If you won't have a chance to work on it I can take care of it next weekend.

@arsduo arsduo merged commit 4b56b0a into arsduo:master Jul 8, 2016
@arsduo
Copy link
Owner

arsduo commented Jul 8, 2016

I've merged this in as API#get_object_metadata and added a test -- thanks for the idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants