Issue 570 - CI process improvements #572
Conversation
|
Odd that you are having issues with tox not running tests. I can run them locally and it seems to work (although there are some issues with respect the the old version of pytest in the requirements and latest python versions). I wonder if it has something to do with tox-travis. Did the verbosity increase give any output which seemed to point to anything? |
|
tox on my local machine works fine too, but in your build https://travis-ci.org/arsenetar/dupeguru/jobs/535353841 it's the same empty output. I wonder if it's not finding the tox testenv correctly or something. |
|
Weird, it works when I explicitly call tox -e WINDOWS like in https://travis-ci.org/jpvlsmv/dupeguru/jobs/535816747 I'll update the PR |
.travis.yml
Outdated
| - choco install python make | ||
| - cp /c/python37/python.exe /c/python37/python3.exe | ||
| before_script: | ||
| - pip install -r requirements-windows.txt |
There was a problem hiding this comment.
Unless there is a reason not to, I think using pip3 for all the pip commands would be more consistent.
| - pip install -r requirements-windows.txt | |
| - pip3 install -r requirements-windows.txt |
| @@ -16,6 +16,10 @@ deps = | |||
| -r{toxinidir}/requirements.txt | |||
| -r{toxinidir}/requirements-extra.txt | |||
|
|
|||
| [testenv:WINDOWS] | |||
| deps = | |||
| -r{toxinidir}/requirements-windows.txt | |||
There was a problem hiding this comment.
Looks like only the windows requirements get installed in the tox environment, we probably want all three sets. So want to add lines 16&17 under deps here as well. As it does not seem to append.
| -r{toxinidir}/requirements-windows.txt | |
| -r{toxinidir}/requirements.txt | |
| -r{toxinidir}/requirements-extra.txt | |
| -r{toxinidir}/requirements-windows.txt |
There was a problem hiding this comment.
Done (via inheritance)
|
Cool, looks like this cleaned up the remaining issues with the windows build on travis. |
These changes bring Windows into the build system. When triggered (by github push) travis-ci will kick off 4 jobs in parallel-- Testing Ubuntu Xenial with Python 3.5, 3.6, and 3.7, plus an early-access Windows VM with python 3.7.
On Linux, the pytest results are passing as expected (since nothing really changed for the Linux builds).
On Windows, tox is behaving oddly-- it isn't recognizing any tests or really anything at all to do, it just says Congratuations. However, the build does critically depend on successful "python3 build.py" so in principle this should be at least a test of compiling the modules.
Additional work could add a after_success task to call package.py and to save the resulting artifact for more testing.
--Joe