Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix standard mode folder comparison view generating "---" in results table #677

Merged
merged 3 commits into from
Jun 24, 2020
Merged

Fix standard mode folder comparison view generating "---" in results table #677

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e89156e
Add temporary workaround for bug #676
glubsy Jun 24, 2020
ed64428
Add missing file class for folder type.
glubsy Jun 24, 2020
bcb2650
Remove superfluous argument
glubsy Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ def _do_delete_dupe(self, dupe, link_deleted, use_hardlinks, direct_deletion):

def _create_file(self, path):
# We add fs.Folder to fileclasses in case the file we're loading contains folder paths.
return fs.get_file(path, self.fileclasses + [fs.Folder])
return fs.get_file(path, self.fileclasses + [se.fs.Folder])

def _get_file(self, str_path):
path = Path(str_path)
Expand Down Expand Up @@ -539,8 +539,8 @@ def empty_data():
return dupe.get_display_info(group, delta)
except Exception as e:
logging.warning(
"Exception on GetDisplayInfo for %s: %s", str(dupe.path), str(e)
)
"Exception (type: %s) on GetDisplayInfo for %s: %s",
type(e), str(dupe.path), str(e))
return empty_data()

def invoke_custom_command(self):
Expand Down