This repository has been archived by the owner on May 6, 2019. It is now read-only.
Fixes: #8 : Added Me to Contributors #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sk9331657 Congrats on your first PR. Small change needed here. Tag the issue number in PR description something like this |
|
@arshadkazmi42 Ok Sir. |
|
@sk9331657 you have still not tagged the issue number in your Pull Request description |
championpaddler
changed the title
|
@arshadkazmi42 Now, it can be merged. |
|
@sk9331657 No need to create new issue, there is issue #8 already there, tag that issue. do not create new issue. |
championpaddler
changed the title
Repository owner
deleted a comment
Oct 1, 2018
|
@arshadkazmi42 Why Codacy is failing ?? |
Repository owner
deleted a comment
Oct 1, 2018
|
@sk9331657 its indentation issue, I am ignoring it for now. I will be creating another issue to fix that. |
|
Congrats @sk9331657 on landing your first PR |
Repository owner
deleted a comment
Oct 1, 2018
|
@arshadkazmi42 Thanks. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Me to Contributors List.
Fixes: #8