Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/yarn over npm #62

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Doc/yarn over npm #62

merged 2 commits into from
Mar 29, 2019

Conversation

cdrani
Copy link
Collaborator

@cdrani cdrani commented Mar 29, 2019

Fixes #56

@cdrani
Copy link
Collaborator Author

cdrani commented Mar 29, 2019

I want to point out that this readme is quite limiting because not all contributions have to be in the form of actual code, but also documentation, finding bugs, etc. Also I don't know about some of the steps:

  1. git add --all. This is dependent on how extensive the .gitignore file is. I think it should say only add the actual files you purposely created or modified by having them check with git status first.
  2. I think it would also be great if the doc included setting up an upstream from their local copy to this remote. ref https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/.
  3. This is a wonderful example of a contributing guide: https://github.com/ollelauribostrom/rebus

This should be opened in it's own issue though.

Copy link
Owner

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank alot for this and all the work you have been doing.

@arshadkazmi42 arshadkazmi42 merged commit 3676035 into arshadkazmi42:master Mar 29, 2019
@arshadkazmi42
Copy link
Owner

I want to point out that this readme is quite limiting because not all contributions have to be in the form of actual code, but also documentation, finding bugs, etc. Also I don't know about some of the steps:

1. `git add --all`. This is dependent on how extensive the .gitignore file is. I think it should say only add the actual files you purposely created or modified by having them check with `git status` first.

2. I think it would also be great if the doc included setting up an upstream from their local copy to this remote. ref https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/.

3. This is a wonderful example of a contributing guide: https://github.com/ollelauribostrom/rebus

This should be opened in it's own issue though.

Created an issue for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants