Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commented out contributors section from readme #24

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

kodi42
Copy link
Contributor

@kodi42 kodi42 commented Feb 2, 2022

No description provided.

Copy link
Owner

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

Lets remove the complete block, we don't want it to be commented.

Once this is done, we can get this merged.

README.md Outdated
@@ -55,11 +55,12 @@ You can log any issues or suggestion related to this library [here](https://gith

Read our contributing [guide](https://github.com/arshadkazmi42/currency-symbols/blob/master/CONTRIBUTING.md) on getting started with contributing to the codebase

## Contributors
<!--- ## Contributors
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just remove the whole block. We don't want it to be commented. Lets just remove it completely.

Copy link
Owner

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Lets get this merged 🎉

@arshadkazmi42 arshadkazmi42 merged commit 89d6de8 into arshadkazmi42:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants