Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the License to MIT License #113

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

Aayush3014
Copy link
Contributor

Fixes #100

I have changed the License to MIT as asked in the mentioned issue by modifying the License File.
Check everything which applies

  • I have added the issue number for which this pull request is created.

@Aayush3014
Copy link
Contributor Author

Hey, I have done the changes as asked. Please review the modification and let me Know if i can help in some other issues.

@arshadkazmi42
Copy link
Owner

@Aayush3014 Thank you for working on this, but there is another PR already created #101 for changing this license before you. So we will have to accept that PR.

We will be closing this PR.

Copy link
Owner

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. can you fix the one request change? Rest looks good

LICENSE Outdated

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
Copyright (c) 2023 Ayush
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ayush => First Issues

@arshadkazmi42 arshadkazmi42 reopened this Apr 16, 2023
@arshadkazmi42
Copy link
Owner

@Aayush3014 we haven't received any updates on the other pull request so I am re-opening your PR. If you could make the requested changes I can get this merged

@Aayush3014
Copy link
Contributor Author

Yeah sure working on it.

Copy link
Owner

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thank you

@arshadkazmi42 arshadkazmi42 merged commit 5680615 into arshadkazmi42:master Apr 16, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change LICENSE to MIT
2 participants