Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo language hastags to tweet #53

Merged
merged 3 commits into from
Sep 5, 2019

Conversation

freddygcala
Copy link
Contributor

Implement #52

One thing to keep in mind is the Rate limit of Github API (for each new tweet there is a request for the repo language). According to the documentation For unauthenticated requests, the rate limit allows for up to 60 requests per hour

I don't see more than 60 tweets per hour so I think it'll be ok.

@freddygcala
Copy link
Contributor Author

The repo languages must be requested if the --only-save option is not passed, to prevent reaching the rate limit when the db.json is created

@arshadkazmi42
Copy link
Owner

@freddygcala Thank you for working on this.
I am not getting much time for reviewing PRs.
I will try to review it, by this week

Copy link
Owner

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome.
Add one thought, let me know what you think about it?

first_timers/first_timers.py Outdated Show resolved Hide resolved
Copy link
Owner

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 💯

@arshadkazmi42 arshadkazmi42 merged commit f3c34a2 into arshadkazmi42:master Sep 5, 2019
@arshadkazmi42
Copy link
Owner

@freddygcala Changes deployed.
First tweet with the changes
https://twitter.com/first_issues/status/1169662243606151168?s=20 👍

@freddygcala freddygcala deleted the repo-languages branch September 5, 2019 19:06
@LeonardoFurtado
Copy link

Amazing PR 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants