Fixes issue #38
Merged
Fixes issue #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arshadkazmi42
requested changes
Jan 11, 2019
PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| [] I have added the issue number for which this pull request is created. | ||
| #### [:heavy_check_mark:] I have added the issue number for which this pull request is created | ||
| #### [:heavy_check_mark:] I have change PULL_REQUEST_TEMPLATE.md |
There was a problem hiding this comment.
We do not want this.
This is a template not the exact change you have done.
PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| Check everything which applies | ||
| ### Check everything which applies : |
There was a problem hiding this comment.
Replace ### with -
Remove :
PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| [] I have added the issue number for which this pull request is created. | ||
| #### [:heavy_check_mark:] I have added the issue number for which this pull request is created |
There was a problem hiding this comment.
Change this to
- [ ] I have added the issue number for which this pull request is created
PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -1,5 +1,6 @@ | |||
| Fixes #issuenumber | |||
| # Fixes #Issues Number [1] | |||
There was a problem hiding this comment.
Let's change this to something like this
Fixes #issue_number
-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
Check everything which applies